Project structure refactoring #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DashaBulanova
approved these changes
Nov 1, 2020
src/Dodo.HttpClient.ResiliencePolicies/HttpClientBuilderExtensionsClients.cs
Outdated
Show resolved
Hide resolved
Now it follows correct naming pattern "{Any additional information}{Extended type}Extensions"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project structure refactoring:
[*] Rename folders to avoid name clashes between namespace and target class, ex:
RetryPolicySettings.[*] Adjust namespaces.
[*] Rename
private static readonlymethods thus they are now camel-case according to style guides (Rider gives same advice).[+] Return back
AddDefaultPoliciesand rename it toAddResiliencePoliciesaccording to #45.[*] Refactor policies methods, now we should pass
ResiliencePoliciesSettingsas an argument instead ofAction<ResiliencePoliciesSettings>.[+] Separate code for policies and code for clients.
[*]
TimeoutSettings.Timeoutproperty is now readonly and filled from the constructor. This is done for the settings unification.Closes #45.