Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception handling on crossbow-android platform #130

Closed
enfipy opened this issue Aug 1, 2022 · 0 comments · Fixed by #121
Closed

Fix exception handling on crossbow-android platform #130

enfipy opened this issue Aug 1, 2022 · 0 comments · Fixed by #121
Assignees
@enfipy
Labels
bug Something isn't working enhancement New feature or request

Comments

@enfipy
Copy link
Collaborator

enfipy commented Aug 1, 2022

Objective

Currently, Android Java Exceptions are not handled properly and resulting in ugly panics.

What problem does this solve, or what need does it fill?

Problem with Exception handling in Rust calls to Java.

What solution would you like?

Use this approach:

// ...call_method...
jnienv.exception_check()?;

Read more in this StackOverflow question and jni docs.
@enfipy enfipy added bug Something isn't working enhancement New feature or request labels Aug 1, 2022
@enfipy enfipy self-assigned this Aug 1, 2022
@enfipy enfipy mentioned this issue Aug 4, 2022
Merged
11 tasks
enfipy added a commit that referenced this issue Aug 4, 2022
@enfipy
Fixes #130, fixes some warnings in AdMob and Crossbow Android
97f351b
@enfipy enfipy closed this as completed in 144b275 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enfipy enfipy

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create single Permission API inside Cargo.toml metadata dodorare/crossbow
1 participant
@enfipy