Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android build on Windows, start_apk function and Kotlin linking #109

Merged
merged 8 commits into from
Jul 18, 2022

Conversation

enfipy
Copy link
Collaborator

@enfipy enfipy commented Jul 18, 2022

Objective

  • Build for android was failing on Windows because of the Path display.
  • Kotlin linking was incorrect.
  • Function start_apk didn't launch the Application if it was built with Gradle.
  • Default command crossbundle build android actually doesn't build apk.
  • Cargo Metadata and Gradle tests were failing.

Solution

  • Use Path with Debug formatting.
  • Use @JvmStatic for Kotlin external functions.
  • Add an argument to the start_apk function to specify the Activity to launch.
  • Launch the gradle build command at the end of the crossbundle build command.
  • Fix tests test_cargo_metadata and test_build_gradle.

Changelog

Important: This change updates all libraries to the 0.1.6 version.

@enfipy enfipy requested review from Adoka3710 and Heezay July 18, 2022 17:18
@enfipy enfipy added bug Something isn't working high priority High priority task labels Jul 18, 2022
@enfipy enfipy merged commit 411c0e4 into main Jul 18, 2022
@enfipy enfipy deleted the fix-android-build branch July 18, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants