Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more circleci build for testing in x86_64 env #43

Merged
merged 11 commits into from Mar 2, 2018

Conversation

nomaddo
Copy link
Collaborator

@nomaddo nomaddo commented Mar 1, 2018

Related: #39

This pullreq add more circleci build specially for building x86_64 versions of the compiler for testing.
This pullreq MUST accept after this pullreq:
doe300/VC4CLStdLib#4

I added two jobs:

  • Build VC4C using SPIRV-LLVM
  • Build VC4C using llvm-lib

The purpose of this pullreq is comparison between one of SPIRV-LLVM and LLVM-LIB with ease.

Copy link
Owner

@doe300 doe300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the native builds compile and run (which I haven't tested), this is a great improvement, thanks!
See my comment for some minor changes.

- run: ln -s `pwd`/build/libVC4CC.so.0.4 /usr/lib/libVC4CC.so.1.2
- run: ln -s `pwd`/build/cpptest-lite/src/cpptest-lite-project-build/libcpptest-lite.so.0.9 /usr/lib/libcpptest-lite.so.1.1.2
- run: ldconfig
- run: build/test/TestVC4C
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestVC4C runs about 15 mins (on my desktop PC), so running it twice on every build is not an option.
I selected a few test-cases which run quite fast (and am working on adding some more):

build/test/TestVC4C --output=plain --mode=verbose --test-instructions --test-operators

Same for the test beneath

@nomaddo nomaddo force-pushed the add_x64_ci branch 3 times, most recently from 7ef4a2f to deec6dc Compare March 2, 2018 07:21
@nomaddo
Copy link
Collaborator Author

nomaddo commented Mar 2, 2018

Fixed.

BTW: Compiling with SPIRV-LLVM is a little bit longer than llvm's.
Is it still better front-end than others?

@doe300
Copy link
Owner

doe300 commented Mar 2, 2018

SPIRV-Tools takes a long time to compile (a few minutes).

While compiling OpenCL-kernels, using the SPIRV-LLVM is faster than using default clang, at least in my experience. Or do you have other measurements?

Edit:
On the question, whether the SPIR-V front-end is "better" than the LLVM library front-end? Maybe at experimental support for image types/operations, but other than that, no.

@doe300 doe300 merged commit 0cf475b into doe300:master Mar 2, 2018
@nomaddo nomaddo deleted the add_x64_ci branch March 8, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants