-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if monetization is enabled on a website #9
Check if monetization is enabled on a website #9
Conversation
- Check for monetization meta tag - Resolve specified payment pointer - Verify that resolved payment pointer is valid Signed-off-by: sharon-wang <sharon-wang-cpsc@outlook.com>
To fix #10 in this PR, I will:
Big thanks to @vezwork for referencing and explaining |
Just read over the SPSP Spec, I think I'm missing this:
This to me sounds like raw endpoint URLs ( @vezwork What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Good to make note of, but I don't think it's worth worrying about unless we come across a problem caused by this. We could add an issue with a low priority tag for this? |
Added #11 with a low priority tag so we can look into this later on :) |
Signed-off-by: sharon-wang <sharon-wang-cpsc@outlook.com>
6e0de78
to
edf1fec
Compare
@vezwork fixed the typo and added a link to Interledger SPSP Endpoint Specification. Merging! |
Fixes: #5, fixes: #10
Open up the console to check if the site is monetized, what the payment pointer is and what the resolved payment pointer is.
Note that the http request is currently synchronous, which is deprecated:
Opened an issue: #10 to note that we should fix this. Ignoring for now since we have a backlog for the prototype.