Change phpunit workflow to run under php 8.1 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-doehring
commented
Sep 10, 2021
| @@ -110,7 +110,7 @@ public function testHttpError(): void | |||
|
|
|||
| $request->expects(self::once())->method('withBody')->with($stream)->willReturnSelf(); | |||
|
|
|||
| $e = $this->createMock(Exception::class); | |||
| $e = new Exception($this->faker()->text()); | |||
There was a problem hiding this comment.
I don't know, but he had some issues with it under php 8.1...
PHP Fatal error: During inheritance of Exception: Uncaught Return type of Mock_Exception_63543ef0::__wakeup() should either be compatible with Exception::__wakeup(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
dogado-json-api-client\tests\Service\OAuth2AuthenticatorTest.php:116
in dogado-json-api-client\vendor\phpunit\phpunit\src\Framework\MockObject\MockClass.php(51) : eval()'d code on line 3
darthsoup
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the phpunit workflow to also run under php 8.1.