Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 8.1 compatibility #4

Merged
merged 1 commit into from
Sep 15, 2021
Merged

php 8.1 compatibility #4

merged 1 commit into from
Sep 15, 2021

Conversation

chris-doehring
Copy link
Contributor

@chris-doehring chris-doehring commented Sep 10, 2021 •
edited
Loading

This PR ensures the compatibility of this package with php8.1. The symfony/http-foundation dependency had to be adjusted, due to the following required change: symfony/symfony@3eca446

Fatal error: During inheritance of IteratorAggregate: Uncaught Return type of Symfony\Component\HttpFoundation\ParameterBag::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

@chris-doehring chris-doehring marked this pull request as ready for review September 10, 2021 22:18
@chris-doehring chris-doehring merged commit 9d06b62 into main Sep 15, 2021
@chris-doehring chris-doehring deleted the feature/php8.1-compatibility branch September 15, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stixxx2k stixxx2k stixxx2k approved these changes

@darthsoup darthsoup Awaiting requested review from darthsoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-doehring @stixxx2k