-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typos and enhanced messages for Polish translation #1844
Fixed typos and enhanced messages for Polish translation #1844
Conversation
Fixed multiple typos (duplicated spaces, misspelled words, etc.) and introduced new messages which were previously not translated to Polish. Also removed couple of redundant numerusforms.
closing & opening to re-trigger CI against 1.14.4-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay with me. Since my Polish is not what it used to be, I'll wait 48h with the merge in case someone has an opinion about the actual translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dogecoinowym - dogecoin'owym (seems better to use apostrophe for English words)
Przycinanie: ostatnia synchronizacja portfela jest za danymi. Muszisz użyć -reindex (pobrać cały ciąg bloków ponownie w przypadku przyciętego węzła)
Musisz - typo
"Przycinanie: ostatnia synchronizacja portfela jest za danymi."
Suggesting change for:
Przycinanie: ostatnia synchronizacja portfela wykracza poza przycięte dane
Because "jest za danymi" can sound confusing and not straightforward.
I see also several dogecoin noun declensions, I would use apostrophe for all of "dogecoin" forms in Polish.
I've done some research on that topic and it seems that apostrophes are intended for words ending with unpronounceable/mute endings (like 'e' in 'iPhone'). In such cases you write iPhone'a. But you should not use apostrophes in words which are easily pronounceable in a declinated form (like iPoda). See:
Because of that I haven't used apostrophes in Dogecoin-related words. Let me know what you think, @sruPL. Regarding the rest of changes - I have unified the case in translations (dogecoin -> Dogecoin), fixed the typo and applied your suggestion of the change. |
Looks fine to me, I guess we learn new things every day :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Since the .idea
addition to .gitignore
in a separate commit, I'm ok with keeping it that way.
Fixed multiple typos (duplicated spaces, misspelled words, etc.) and introduced new messages which were previously not translated to Polish. Also removed couple of redundant numerusforms.