Paper wallet dialog warning update

[peoplma]

Make it clear in dialog that paper wallet privkeys are not saved.

[langerhans]

This warning only appears when you try to print paper wallets while being connected to any other nodes. Are you sure this is the right place for this warning? But maybe I'm putting too much faith in the users by assuming most of them would actually only generate paper wallets on an air gapped machine ;)

[peoplma]

Yeah, people using it offline probably already know what they are doing. Hmm, maybe get rid of the if statement, change the dialog title to just "warning" and have it show up every time?

[langerhans]

Pretty sure, the online warning should stay, I have hopes that people can learn ;)

Maybe we can put your warning somewhere else? Into the actual dialog? Or, we could check if the user actually clicked the "Print" button before they close the window?

[peoplma]

Oh I wasn't suggesting getting rid of the online warning, just showing it no matter if you have connections or not (after all, 0 connections doesn't necessarily mean the computer is offline). So that the warning shows everytime you open the paper wallet generator.

But either of those other options would work too :)

[patricklodder]

@langerhans do we still want to push this? Needs some rework / conflict resolution for 1.14.3.

[patricklodder]

I'm taking this off the critical path for 1.14.3 as this still needs conflict resolution.

[patricklodder]

If this still makes sense to change, please reopen against 1.14.4-dev or 1.21-dev.