Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clarify 1.14.5 release notes #2667

Merged

Conversation

patricklodder
Copy link
Member

IMPORTANT: I changed the reservations around BDB 5.3 upgrades, as this was confirmed to not cause any issues and I personally have not experienced any issues on either Ubuntu (20.04, 21.04) and macOS since, having switched between wallets created with both versions multiple times. If there is ANY doubt that there is a compatibility issue, then we MUST revert this change because this is a minor release.

Updated the 1.14.5 release notes to:

  • Include final code changes
  • Explicitly mention that this now contains an important security update and recommend immediate update
  • Clarify the new fee recommendation
    • Split wallet and relay policy changes
    • Link to the new recommendation document
    • Elaborate benefits and workarounds
    • Fix the wallet fee to be 0.01 DOGE, not 0.001.
  • Reworded the version display in terms of user benefits instead of developer benefits.
  • Shortened the section on key derivation path to be more concise, confident and just list the benefit.
  • Reworded the section on the re-added auxpow methods, focusing on actual miner benefits
  • Separated the RPC API changes as that's always a section of its own.
  • Created a section about build system and CI, because those affect the useful life and thought it more useful to combine multiple improvements there
  • Minor changes:
    • removed some of the individual commit changes that are now mentioned under the build system change
    • Added pruning test because in the past advice has been given that pruning doesn't work, and now it's proven to work
    • Reworded some of the changes to be more concise
  • Fixed hard line endings to be more consistent with 80 characters (it was done in some places but not others)

@patricklodder patricklodder added this to the 1.14.5 milestone Nov 4, 2021
@patricklodder patricklodder requested a review from a team November 4, 2021 16:00
@patricklodder patricklodder added this to In progress in 1.14.5 via automation Nov 4, 2021
@patricklodder patricklodder mentioned this pull request Nov 4, 2021
27 tasks
rnicoll
rnicoll previously approved these changes Nov 4, 2021
Copy link
Contributor

@rnicoll rnicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit pick to clarify for non-technical users, then good to merge.

Realised I could check the BDB release notes, they confirm database file format has not changed:

Log format has changed, in case we want to note it's important to ensure the node has shut down before upgrading, but I think we're okay to leave that.

doc/release-notes.md Outdated Show resolved Hide resolved
1.14.5 automation moved this from In progress to Reviewer approved Nov 4, 2021
1.14.5 automation moved this from Reviewer approved to Review in progress Nov 4, 2021
@patricklodder patricklodder marked this pull request as draft November 5, 2021 12:58
@patricklodder
Copy link
Member Author

Drafting notes to include additional security fix for #2672.

@patricklodder patricklodder marked this pull request as ready for review November 5, 2021 16:02
doc/release-notes.md Outdated Show resolved Hide resolved
@patricklodder
Copy link
Member Author

Updated to fix @edtubbs' comment and squash-rebased.

1.14.5 automation moved this from Review in progress to Reviewer approved Nov 7, 2021
@rnicoll rnicoll merged commit b6abd84 into dogecoin:1.14.5-dev Nov 7, 2021
1.14.5 automation moved this from Reviewer approved to Done Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants