Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Polish Translation, 1.14.7 #3431

Merged

Conversation

danielw86dev
Copy link
Contributor

No description provided.

@patricklodder patricklodder mentioned this pull request Feb 19, 2024
43 tasks
@patricklodder patricklodder requested a review from a team February 19, 2024 22:28
@patricklodder patricklodder added this to the 1.14.7 milestone Feb 19, 2024
@patricklodder patricklodder added this to 🚀 needs review in Review & merge board Feb 19, 2024
@patricklodder
Copy link
Member

Thank you! This looks like a great improvement for the Polish translation.

I've tagged with help wanted; let's find a Polish shibe that can review.

@danielw86dev
Copy link
Contributor Author

danielw86dev commented Feb 22, 2024

I hope so

If not, I have suggestions:
-Can we set the default and recommended language to use English (because it is the base language)
-Mark all other translations as "community made". Point out that, despite the best intentions, they may contain inaccuracies. (because no one can guarantee it, no matter how many reviews there are)
-This approach will create an impression of greater coherence than "mixing strings" at the start.

leaving the idea for consideration
thanks

@mangekyousharingan
Copy link

checked almost half, going to add more later 👀

Copy link

@mangekyousharingan mangekyousharingan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all. Added my suggestions as a comments for which I am open for a discussion.
Great work has been done so far 👏

src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_pl.ts Show resolved Hide resolved
@danielw86dev
Copy link
Contributor Author

danielw86dev commented Feb 23, 2024

Thank you very much for your help. I made changes and added a comment with an explanation where I did not make corrections.

Let know what you think and let's go :)

@patricklodder
Copy link
Member

@danielw86dev are you able to squash your commits, or shall I do it for you?

@danielw86dev
Copy link
Contributor Author

i add one commit (revert button label in print paper wallet) and try do it

Update polish translate in bitcoin_pl.ts
@danielw86dev
Copy link
Contributor Author

Done. @mangekyousharingan again thank you very much, a good piece of work was done, in very short time

Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - code review good

Language validated by @mangekyousharingan

@patricklodder patricklodder merged commit 50a1a00 into dogecoin:1.14.7-dev Feb 25, 2024
14 checks passed
@patricklodder patricklodder removed this from 🚀 needs review in Review & merge board Feb 25, 2024
@mangekyousharingan
Copy link

Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants