sign: add message signing and verification #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-signing functions are now residing in sign.h and sign.c -key functions to do with eckey structure are now in key.c -added sign.h/.c to Makefile.am and CMakeLists.txt
-refactored message signing & verification functions to append the recid on the end of the signature. -added updated functions to corresponding documentation. -added new new_eckey_from_privkey function to derive an eckey pair from a WIF encoded private key.
-verifymessage now requires passing an address to it as this allows us to determine which network prefixes are needed for creating the correct address from the recovered public key. -added is_testnet bool to new_eckey and start_key functions as new_eckey was the only function wherein we can't determine what chainparams are needed, thus let the user decide. -updated documentation and example to reflect said changes.
xanimo
force-pushed
the
0.1.2-dev-msg-signing
branch
from
46e35fe
to
de4df7e
Compare
-per spec's from core, each signed message is prepended with 'Dogecoin Signed Message:\n' which is now implemented in all signed messages.
xanimo
force-pushed
the
0.1.2-dev-msg-signing
branch
from
de4df7e
to
fdefb02
Compare
|
Force pushed to amend the commit message to include a forgotten detail. |
xanimo
force-pushed
the
0.1.2-dev-msg-signing
branch
from
7daa2b7
to
16b6c8e
Compare
|
Greatly simplified the implementation with the help of @edtubbs over the weekend. There is only |
edtubbs
approved these changes
Mar 20, 2023
This was referenced Mar 20, 2023
xanimo
added a commit
to xanimo/libdogecoin
that referenced
this pull request
Mar 22, 2023
…igning sign: add message signing and verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces message signing and verification into libdogecoin. It adheres to BIP-137 although is only applicable for P2PKH addressing and is slightly different considering we append the
recidto the end of the signature if therecid!= 0. This is needed in order to recover the public key in the verification step later on.There are two implementations, one (
signmsgwithprivkeyandverifymessage) returns the signature as achar*and verifies the signature by passing a corresponding address into the verification function and the other (signmsgwitheckeyandverifymessagewithsig) uses theeckeystructure andsignaturestructure to either auto generate a random privkey/pubkey pair or derives it from a private key in WIF format. This allows us to set the correct chain parameters for the rest of the usage throughout the process.For instance, in
suchthere is a hybrid implementation that uses theeckeyandsignaturestructures for the signing as we don't know the address and only provide the message we want to sign and the private key. On the verification step we can then pass the message, the signature and the corresponding address affiliated.There is documentation for the API's (
eckey.md,signing.mdandtools.md) and corresponding examples withincontrib/example.c.