Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thx with args #199

Merged
merged 5 commits into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@AnEmortalKid
Copy link
Member

commented Mar 5, 2019

Part of #194 , this time handling the case with arguments

@AnEmortalKid AnEmortalKid requested review from Pholey and vpzomtrrfrt Mar 5, 2019

@AnEmortalKid AnEmortalKid referenced this pull request Mar 8, 2019

Merged

Control flow recurse #200

@vpzomtrrfrt

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Nested function calls would be worth adding tests for too

@AnEmortalKid

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Nested function calls would be worth adding tests for too

Umm, mind sharing an example? If it’s with the much keyword I think I have an idea. Or are you thinking of the chained ones like bar().baz()

@vpzomtrrfrt

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Nested function calls would be worth adding tests for too

Umm, mind sharing an example? If it’s with the much keyword I think I have an idea. Or are you thinking of the chained ones like bar().baz()

I was thinking more like plz a with b plz c with d e thx f thx

@AnEmortalKid

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2019

Ah, plz a with b plz c with d e thx f thx

To produce a(b, c(d,e)).

I don’t think I’ve handled that yet, but I’ll see if the handling of arguments is enough!

@AnEmortalKid

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2019

Welll, that's gonna need some work

$ dogescript testlet.djs
a(b, plz, c, with, d, e)f thx

$ cat testlet.djs
plz a with b plz c with d e thx f thx

Mostly cause of the way the arguments are handled: https://github.com/dogescript/dogescript/pull/199/files#diff-3fab227e34d65fe9bb2d6ea53eec41cfR712

I've done some exploration of trying to tackle the ambiguity of keywords here #200 by making a stack of states (of kinds). I'll create an issue to follow up on seeing what it's gonna take to make that case work

@vpzomtrrfrt ^

@AnEmortalKid

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Logged #201 to address testing gaps.

@AnEmortalKid AnEmortalKid merged commit 8932103 into dogescript:master Mar 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AnEmortalKid AnEmortalKid deleted the AnEmortalKid:thx-with-args branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.