Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still crashing a little #18

Closed
CodeReaper opened this issue Feb 21, 2017 · 5 comments
Closed

Still crashing a little #18

CodeReaper opened this issue Feb 21, 2017 · 5 comments

Comments

@CodeReaper
Copy link

Hmmm... I have just now noticed you asked me to check the develop branch on #16.

I am seeing code ala:

if optional  == nil { return }
// and then using optional! (explicitly unwrapped)

... which concerns me a bit. Since I am back here looking at issues because I have had another !-related crash. :)

I am willing to arrange the code to avoid using explicitly unwrapped optionals and use lets and guards instead unless you would rather do it yourself or do something different to avoid crashing. What do you think?

@dogo
Copy link
Owner

dogo commented Feb 21, 2017

Hi @CodeReaper , It will be nice a PR removing force unwraps. I was trying to spare some time to do this, but you know... time is short =(

@CodeReaper
Copy link
Author

@dogo Okay expect a PR soonish...

@dogo
Copy link
Owner

dogo commented Feb 22, 2017

@CodeReaper feel free to close this issue, when you have time to validate you PR

@CodeReaper
Copy link
Author

@dogo I validated it as best I can, but I am thinking the issue stays open until a new version is published. :)

@dogo
Copy link
Owner

dogo commented Feb 22, 2017

Please update to 1.3.5

@dogo dogo closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants