Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template_debug mechanism #25

Closed
simonw opened this issue Sep 18, 2020 · 2 comments
Closed

template_debug mechanism #25

simonw opened this issue Sep 18, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Collaborator

simonw commented Sep 18, 2020

I'd prefer it if errors in these template fragments were displayed as errors inline where the fragment should have been inserted, rather than 500ing the whole page - especially since the template fragments are user-provided and could have all kinds of odd errors in them which should be as easy to debug as possible.
Originally posted by @simonw in #24 (comment)
@simonw simonw added the enhancement New feature or request label Sep 18, 2020
@simonw
Copy link
Collaborator Author

simonw commented Sep 18, 2020

I'm going to make this a new plugin configuration setting, template_debug.

@simonw simonw closed this as completed in 534fc96 Sep 18, 2020
@simonw
Copy link
Collaborator Author

simonw commented Sep 18, 2020

Documented here: https://github.com/dogsheep/dogsheep-beta/blob/534fc9689227eba70e69a45da0cee5820bbda9e1/README.md#datasette-plugin

simonw added a commit that referenced this issue Sep 18, 2020
@simonw
Release 0.8
ab36101 
Refs #23, #24, #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw