Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and milestone should have foreign key to repo #31

Closed
simonw opened this issue Apr 21, 2020 · 3 comments
Closed

Issue and milestone should have foreign key to repo #31

simonw opened this issue Apr 21, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Collaborator

simonw commented Apr 21, 2020

Currently the repo column on those tables is a string simonw/datasette rather than an ID referencing a row in repos.

Originally posted by @simonw in #29 (comment)

@simonw simonw added the enhancement New feature or request label Apr 21, 2020
@simonw
Copy link
Collaborator Author

simonw commented Apr 21, 2020

The API just gives us the repository_url: https://api.github.com/repos/simonw/datasette/issues

Mozilla_Firefox_and_Topic__Week_2__Discussion__Submit_your_six_story_points_here

We currently turn that into a simonw/datasette string here:

# Add repo key
issue["repo"] = original["repository_url"].split(
"https://api.github.com/repos/"
)[1]

@simonw
Copy link
Collaborator Author

simonw commented Apr 21, 2020

Since this represents a breaking schema change for anyone running SQL queries against these tables, I'm going to do a major version bump to 2.0 when I release this.

@simonw
Copy link
Collaborator Author

simonw commented Apr 22, 2020

@simonw simonw closed this as completed Apr 22, 2020
simonw added a commit that referenced this issue Apr 22, 2020
Backwards incompatible schema change, refs #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant