Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use raise_for_status() everywhere #45

Open
simonw opened this issue Apr 19, 2020 · 1 comment
Open

Use raise_for_status() everywhere #45

simonw opened this issue Apr 19, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@simonw
Copy link
Collaborator

simonw commented Apr 19, 2020

I keep seeing errors which I think are caused by authentication or rate limit problems but which appear to be unexpected JSON responses - presumably because they are actually an error message.

Recent example: https://github.com/simonw/jsk-fellows-on-twitter/runs/598892575

Using response.raise_for_status() everywhere will make these errors less confusing.
@simonw simonw added the bug Something isn't working label Apr 19, 2020
@simonw
Copy link
Collaborator Author

simonw commented Apr 19, 2020

44714E00-8CC5-46CD-9E48-1F4DD148FCC8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw