Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI broken due to NSS 3.73 #832

Closed
edewata opened this issue Dec 14, 2021 · 1 comment · Fixed by #857
Closed

CI broken due to NSS 3.73 #832

edewata opened this issue Dec 14, 2021 · 1 comment · Fixed by #857

Comments

@edewata
Copy link
Contributor

edewata commented Dec 14, 2021

Currently the PKCS11 test is broken due to the new constants introduced in NSS 3.73:
https://github.com/dogtagpki/jss/runs/4515074676
nss-dev/nss@e6c170e

One option is to add the new constants into PKCS11Constants.java, but it might not work on platforms that do not have NSS 3.73 yet.

Another option is to define Conflicts: in jss.spec against NSS 3.73 or later.

Another option is to let the CI fail until NSS 3.73 becomes more widely available.
@cipherboy
Copy link
Member

There's only a few places where JSS actually exposes a raw PKCS#11-ish interface (and hence, less used among our consumers and low risk of failure). These new constants are all vendor-specific too (CK*_NSS_* -- not prone to being used, especially by people just looking for a replacement for the thing the JDK removed) so from my point of view, 1 and 3 seem the best. My 2c :-)

edewata added a commit to edewata/jss that referenced this issue Apr 2, 2022
@edewata
Update PKCS11Constants
39cb81d 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: dogtagpki#832
edewata added a commit to edewata/jss that referenced this issue Apr 2, 2022
@edewata
Update PKCS11Constants
276eb39 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: dogtagpki#832
@edewata edewata mentioned this issue Apr 2, 2022
Merged
edewata added a commit that referenced this issue Apr 4, 2022
@edewata
Update PKCS11Constants
71b93e7 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: #832
edewata added a commit to edewata/jss that referenced this issue May 3, 2022
@edewata
Update PKCS11Constants
0304e54 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: dogtagpki#832
edewata added a commit that referenced this issue May 3, 2022
@edewata
Update PKCS11Constants
2d8c2a0 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: #832
edewata added a commit to edewata/jss that referenced this issue May 9, 2022
@edewata
Update PKCS11Constants
7de489d 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: dogtagpki#832
edewata added a commit to edewata/jss that referenced this issue Jun 15, 2022
@edewata
Update PKCS11Constants
181767c 
The PKCS11Constants class has been updated to include the new
constants introduced in NSS 3.73.

Resolves: dogtagpki#832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PKCS11Constants edewata/jss
2 participants
@cipherboy @edewata