Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate name in manifest warnings #22

Merged
merged 1 commit into from
Sep 20, 2018
Merged

duplicate name in manifest warnings #22

merged 1 commit into from
Sep 20, 2018

Conversation

emaldona
Copy link
Contributor

@emaldona emaldona changed the title Duplicate name in manifest warning branch Fix duplicate name in manifest warnings Aug 16, 2018
@emaldona emaldona changed the title Fix duplicate name in manifest warnings duplicate name in manifest warnings Aug 17, 2018
@cipherboy
Copy link
Member

I have:

  • Tested and built this PR locally.
  • Verified that the issue is valid.
    [jss@localhost ~]$ grep 'WARNING:' ./jss_master*
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Name.
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Specification-Title.
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Specification-Version.
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Specification-Vendor.
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Implementation-Title.
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Implementation-Version.
    ./jss_master_build.stderr:WARNING: Duplicate name in Manifest: Implementation-Vendor.
    ```
    
  • Verified that it removes the warning from the referenced issue.
    [jss@localhost ~]$ grep 'WARNING:' ./jss_branch*
    [jss@localhost ~]$ 
    

Thanks for the PR @emaldona! :)

@cipherboy cipherboy merged commit e68ba5d into dogtagpki:master Sep 20, 2018
@cipherboy cipherboy self-assigned this Sep 20, 2018
@cipherboy cipherboy requested review from cipherboy and removed request for cipherboy September 20, 2018 18:52
@cipherboy
Copy link
Member

cipherboy commented Sep 20, 2018

For future reference (AI: @cipherboy):

In the code, it isn't obvious but the variable $append is local and static. The local part is fixed by #30, but removing the conditional would be nice. In particular, it seems like the append behavior isn't desired.

@cipherboy cipherboy added Bug Something isn't working Build Changes related to the build system labels Oct 10, 2018
@cipherboy cipherboy added this to the 4.5.1 milestone Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Build Changes related to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants