Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup all.pl to address test_perl_style.sh tool messages #31

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Cleanup all.pl to address test_perl_style.sh tool messages #31

merged 2 commits into from
Oct 2, 2018

Conversation

emaldona
Copy link
Contributor

@emaldona emaldona commented Oct 1, 2018

  • Address https://pagure.io/jss/issue/23

  • perl -Mstrict -Mdiagnostics -cw org/mozilla/jss/tests/all.pl

  • now shows org/mozilla/jss/tests/all.pl syntax OK

emaldona and others added 2 commits October 1, 2018 14:42
@emaldona
Cleanup all.pl to address test_perl_style.sh tool messages
6002184 
- Address https://pagure.io/jss/issue/23

- perl -Mstrict -Mdiagnostics -cw org/mozilla/jss/tests/all.pl
- outputs org/mozilla/jss/tests/all.pl syntax OK
@cipherboy
Add org/mozilla/jss/tests/all.pl to tools/test_perl_style.sh
3e5887d 
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
@cipherboy cipherboy self-assigned this Oct 2, 2018
@cipherboy
Copy link
Member

Okay, I have added another commit that adds this to the tools/test_perl_style.sh script. Simpler than creating another PR or having you update it. :)

Pending CI, I'll merge.

I've validated:

  • That this still runs the tests and doesn't affect their output
  • That intentionally making the tests fail does indeed cause failure in the resulting script.
  • That the changes look sane.

Thanks @emaldona! :)

@cipherboy cipherboy merged commit 7cd4b41 into dogtagpki:master Oct 2, 2018
@emaldona emaldona deleted the CLEANUP_TEST_SCRIPT_BRANCH branch October 2, 2018 15:00
@emaldona emaldona restored the CLEANUP_TEST_SCRIPT_BRANCH branch October 2, 2018 15:00
@cipherboy cipherboy added the Build Changes related to the build system label Oct 10, 2018
@cipherboy cipherboy added this to the 4.5.1 milestone Oct 10, 2018
@emaldona emaldona deleted the CLEANUP_TEST_SCRIPT_BRANCH branch October 12, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

Assignees

@cipherboy cipherboy

Labels
Build Changes related to the build system
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emaldona @cipherboy