Add documentation about JSS #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
changed the title
cipherboy
force-pushed
the
documentation
branch
from
c70c133
to
d6ca0d1
Compare
SilleBille
reviewed
Oct 10, 2018
docs/CI.md
Outdated
| @@ -0,0 +1,24 @@ | |||
| # Containers and Continuous Integration | |||
|
|
|||
| JSS uses [Travis CI](https://travis-ci.com/about) for PR gating. We use | |||
There was a problem hiding this comment.
How about adding the Travis link to repo instead of about? https://travis-ci.org/dogtagpki/jss
docs/CI.md
Outdated
| [Podman docs](https://github.com/containers/libpod/tree/master/docs). | ||
|
|
||
| To skip running CI for a given commit (e.g., for updating documentation), | ||
| append `[skip ci]` to the commit summary. |
There was a problem hiding this comment.
How about adding a note something like "Even though test runs against ubuntu, the final build results are considered Success even if ubuntu build fails"? This will avoid the user from assuming that the CI has bugs when a user sees a X mark against ubuntu but still his/her PR passes. Your thoughts?
cipherboy
force-pushed
the
documentation
branch
from
d6ca0d1
to
32581a6
Compare
|
@SilleBille These comments should now be addressed, thanks! |
cipherboy
force-pushed
the
documentation
branch
from
32581a6
to
dcb297d
Compare
cipherboy
changed the title
- Different interfaces with the build system - Environment variables recognized by the build system Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
force-pushed
the
documentation
branch
from
dcb297d
to
5e18907
Compare
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
force-pushed
the
documentation
branch
from
5e18907
to
f4913ab
Compare
cipherboy
added
docs
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
|
This now includes documentation on the new Merging as it is now complete and has been spellchecked. Further documentation can be added or revised later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial step in improving documentation about JSS. In particular, this PR documents two aspects:
The latter is important as 389-console appears to be using JSS without including
slf4j-api.jarin the classpath.