Remove space from AlgorithmId.toString() #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cadc299 and v4.4.x commit e1ee07a, AlgorithmId was updated to unconditionally add an extra space to toString, to separate the algorithm name from the parameters. This suffices in some cases, but AlgorithmId.toString() is used by PKI to compare against a tokenized list of characters. Removing the extraneous whitespace was the solution proposed in PKI commit 53de751485b04fe2a1555228342ed642c9a9e347, but this should really be handled in JSS instead of PKI. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
added
Bug
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cadc299 and
v4.4.xcommite1ee07a,
AlgorithmIdwas updatedto unconditionally add an extra space to
toString, to separate thealgorithm name from the parameters. This suffices in some cases, but
AlgorithmId.toString()is used by PKI to compare against a tokenizedlist of characters. Removing the extraneous whitespace was the solution
proposed in PKI commit
dogtagpki/pki@53de7514, butthis should really be handled in JSS instead of PKI.
Signed-off-by: Alexander Scheel <ascheel@redhat.com>See also: dogtagpki/pki#364