Added PK11RSAPrivateKey.getModulus() #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagne
reviewed
Jun 12, 2018
| } | ||
|
|
||
| // get slot from private key | ||
| slot = PK11_GetSlotFromPrivateKey(privateKey); |
There was a problem hiding this comment.
I think you need to free that slot object: See here: https://dxr.mozilla.org/security/source/mozilla/security/nss/lib/ssl/ssl3con.c#5359
The PK11RSAPrivateKey.getModulus() has been modified to get the modulus from the public key, which was converted from the private key using SECKEY_ConvertToPublicKey(). A new PK11Exception has been added as a generic exception for all PKCS dogtagpki#11-related errors. https://pagure.io/jss/issue/9
jmagne
approved these changes
Jun 13, 2018
edewata
added a commit
to edewata/jss
that referenced
this pull request
Feb 15, 2021
The CertificateChain class has been modified to support importing/exporting certificates from/to a series of PEM certificates and PKCS dogtagpki#7 data.
edewata
added a commit
to edewata/jss
that referenced
this pull request
Feb 15, 2021
The CertificateChain class has been modified to support importing/exporting certificates from/to a series of PEM certificates or PKCS dogtagpki#7 data.
edewata
added a commit
to edewata/jss
that referenced
this pull request
Feb 17, 2021
The CertificateChain class has been modified to support importing/exporting certificates from/to a series of PEM certificates or PKCS dogtagpki#7 data.
edewata
added a commit
to edewata/jss
that referenced
this pull request
Feb 17, 2021
The CertificateChain class has been modified to support importing/exporting certificates from/to a series of PEM certificates or PKCS dogtagpki#7 data.
edewata
added a commit
that referenced
this pull request
Feb 17, 2021
The CertificateChain class has been modified to support importing/exporting certificates from/to a series of PEM certificates or PKCS #7 data.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PK11RSAPrivateKey.getModulus() has been modified to get the
modulus from the public key, which was converted from the private
key using SECKEY_ConvertToPublicKey().
A new PK11Exception has been added as a generic exception for all
PKCS #11-related errors.
https://pagure.io/jss/issue/9