Skip to content

Commit

Permalink
No missing token in verify_certificate_exists
Browse files Browse the repository at this point in the history
Remove the missing token check from verify_certificate_exists. It was
the one place that was not adopted to use blank token as default.

Change-Id: Ic192e0699ff32af474976039af08e1503925dfd1
See: 17677ae
Fixes: https://pagure.io/dogtagpki/issue/3073
Signed-off-by: Christian Heimes <cheimes@redhat.com>
  • Loading branch information
tiran authored and edewata committed Oct 25, 2018
1 parent 8fe7d8b commit 0fba3c2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions base/server/python/pki/server/deployment/pkihelper.py
Expand Up @@ -2436,11 +2436,6 @@ def verify_certificate_exists(self, path, token, nickname,
# Specify the 'token'
if token:
command.extend(["-h", token])
else:
config.pki_log.error(
log.PKIHELPER_CERTUTIL_MISSING_TOKEN,
extra=config.PKI_INDENTATION_LEVEL_2)
raise Exception(log.PKIHELPER_CERTUTIL_MISSING_TOKEN)
# Specify the nickname of this self-signed certificate
if nickname:
command.extend(["-n", nickname])
Expand Down
1 change: 0 additions & 1 deletion base/server/python/pki/server/deployment/pkimessages.py
Expand Up @@ -188,7 +188,6 @@
PKIHELPER_CERTUTIL_MISSING_SERIAL_NUMBER = \
"certutil: Missing '-m serial-number' option!"
PKIHELPER_CERTUTIL_MISSING_SUBJECT = "certutil: Missing '-s subject' option!"
PKIHELPER_CERTUTIL_MISSING_TOKEN = "certutil: Missing '-h token' option!"
PKIHELPER_CERTUTIL_MISSING_TRUSTARGS = \
"certutil: Missing '-t trustargs' option!"
PKIHELPER_CERTUTIL_MISSING_VALIDITY_PERIOD = \
Expand Down

0 comments on commit 0fba3c2

Please sign in to comment.