Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_certificate_exists still fails when token is empty #3190

Closed
pki-bot opened this issue Oct 3, 2020 · 10 comments
Closed

verify_certificate_exists still fails when token is empty #3190

pki-bot opened this issue Oct 3, 2020 · 10 comments
Milestone

Comments

@pki-bot
Copy link

pki-bot commented Oct 3, 2020

This issue was migrated from Pagure Issue #3073. Originally filed by cheimes (@tiran) on 2018-10-25 08:49:58:


Commit 17677ae changed how default token name is handled. Dogtag now passes None to signal default internal token. However verify_certificate_exists method was not changed. This bug breaks some of FreeIPA CI tests like TestServerReplicaCALessToCAFull.

@pki-bot pki-bot added this to the 10.6.8 milestone Oct 3, 2020
@pki-bot pki-bot closed this as completed Oct 3, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from cheimes (@tiran) at 2018-10-25 09:12:19

PR #80

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from cheimes (@tiran) at 2018-10-25 09:12:20

Metadata Update from @tiran:

  • Custom field component adjusted to None
  • Custom field feature adjusted to None
  • Custom field origin adjusted to None
  • Custom field proposedmilestone adjusted to None
  • Custom field proposedpriority adjusted to None
  • Custom field reviewer adjusted to None
  • Custom field type adjusted to None
  • Custom field version adjusted to None

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from cheimes (@tiran) at 2018-10-25 09:59:05

Committed 0fba3c2

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-25 10:07:45

The fix has been pushed to master:

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-25 10:07:46

Metadata Update from @edewata:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-25 10:11:41

Metadata Update from @edewata:

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-26 00:14:17

Metadata Update from @edewata:

  • Issue status updated to: Open (was: Closed)

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-26 00:15:32

Apparently there is a related bug:
#83

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-26 13:26:37

Fixed in master branch:

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2018-10-26 13:26:38

Metadata Update from @edewata:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant