CryptoUtil.getKeywrapAlgorithmFromOID: Fix DES-EDE3-CBC selection #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dbd2d9b contained the edit: - if (oid.equals(KW_DES_CBC_PAD)) + if (oid.equals(KeyWrapAlgorithm.DES_CBC_PAD_OID)) KW_DES_CBC_PAD was 1.2.840.113549.3.7 (DES-EDE3-CBC; this definition was removed in the same commit). But KeyWrapAlgorithm.DES_CBC_PAD_OID is 1.3.14.3.2.7. This is a behaviour change that breaks KRA archival (possibly recovery too). Test equality to KeyWrapAlgorithm.DES3_CBC_PAD_OID to restore the correct behaviour. Also fix a similar error in WrappingParams.java. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1709585
ladycfu
approved these changes
Sep 19, 2019
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit dbd2d9b contained the edit:
KW_DES_CBC_PAD was 1.2.840.113549.3.7 (DES-EDE3-CBC; this definition was
removed in the same commit). But KeyWrapAlgorithm.DES_CBC_PAD_OID is
1.3.14.3.2.7. This is a behaviour change that breaks KRA archival
(possibly recovery too).
Test equality to KeyWrapAlgorithm.DES3_CBC_PAD_OID to restore the correct
behaviour. Also fix a similar error in WrappingParams.java.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1709585