Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkispawn man page with instructions to dscreate #3348

Merged
merged 2 commits into from Oct 7, 2020

Conversation

SilleBille
Copy link
Member

@SilleBille SilleBille commented Oct 7, 2020

This patch updates pkispawn's man page with instructions
to install a DS instance using dscreate.

Partly resolves: bz#1656772

Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>

This patch updates pkispawn's man page with instructions
to install a DS instance using dscreate.

Partly resolves: bz#1656772

Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
Copy link
Member Author

@SilleBille SilleBille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The man page seems to be quite old and needs to revised again. Maybe @fdelehay can help us verify and point outdated instructions? 😄

Stop the Directory Server instance:

```
$ systemctl stop dirsrv@pki.service
```

Enable LDAPS in the Directory Server with the following command:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script doesn't seem to work anymore. IMO, the contents (or steps) from the script should be moved into the man page, for systems with offline access.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an unofficial instruction on DS setup here:
https://github.com/dogtagpki/pki/wiki/DS-1.4-Installation

But I don't think we should be including DS setup instruction in PKI docs because it's outside our scope. I'd rather we just refer to DS docs, and only specify what PKI needs in PKI docs, for example:

  • Hostname and port number
  • Bind DN and password, or client certificate
  • Base DN

So probably lines 1342-1385 can be replaced with something like: Set up a Directory Server instance with a self-signed CA certificate (see dscreate(8)), then export the certificate into a PEM file.

Also, we can remove all references to dirsrv.target.

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments below, but if you think that will require a lot more work feel free to merge what you have now. Thanks!

Comment on lines 1453 to 1456
To obtain a detailed status of all Tomcat PKI instances:

```
$ pkidaemon status tomcat
$ pki-server status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part can be removed. pki-server status will only work with one instance at a time.

Stop the Directory Server instance:

```
$ systemctl stop dirsrv@pki.service
```

Enable LDAPS in the Directory Server with the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an unofficial instruction on DS setup here:
https://github.com/dogtagpki/pki/wiki/DS-1.4-Installation

But I don't think we should be including DS setup instruction in PKI docs because it's outside our scope. I'd rather we just refer to DS docs, and only specify what PKI needs in PKI docs, for example:

  • Hostname and port number
  • Bind DN and password, or client certificate
  • Base DN

So probably lines 1342-1385 can be replaced with something like: Set up a Directory Server instance with a self-signed CA certificate (see dscreate(8)), then export the certificate into a PEM file.

Also, we can remove all references to dirsrv.target.

This patch:
- Fixes issue with angle brackets in pkispawn man page
- Removes obsolete DS specific information from pkispawn man page

Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
@SilleBille
Copy link
Member Author

Merging based on the ACK! Thanks @edewata

@SilleBille SilleBille merged commit 15e78c2 into dogtagpki:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants