acme: add SANToCNDefault to registry #354
Conversation
ACME profiles need the SANToCNDefault profile component in the registry. This commit will add it for new installations. A future change (perhaps in FreeIPA rather than Dogtag) will address adding the component to the registry on upgrade.
There was a problem hiding this comment.
LGTM, feel free to merge.
Question, why not add the upgrade script in PKI? This change is made in PKI so there will be a discrepancy between new PKI instances and old ones without an upgrade script.
FYI, I'm considering to add CLIs to manage the registry properties so it's easier to update them.
@cipherboy What do you think?
|
For my reference: added in #287 I think should add this in the default. I also agree with @edewata that if we want this by default (it seems we have consensus we do) -- we should put an upgrade script in PKI to do this. I don't care if that's this PR or if @edewata or @frasertweedale opens a new to do so. :-) |
|
I'm fine with Dogtag upgrade script too. |
|
And I added a pagure ticket: https://pagure.io/dogtagpki/issue/3169 |
ACME profiles need the SANToCNDefault profile component in the
registry. This commit will add it for new installations. A future
change (perhaps in FreeIPA rather than Dogtag) will address adding
the component to the registry on upgrade.