Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACIs with the correct syntax #397

Merged
merged 1 commit into from May 4, 2020
Merged

Conversation

vashirov
Copy link
Contributor

The value of the first character in target* keywords
is expected to be a double quote.

Fixes: https://pagure.io/dogtagpki/issue/3173

Signed-off-by: Viktor Ashirov vashirov@redhat.com

The value of the first character in target* keywords
is expected to be a double quote.

Fixes: https://pagure.io/dogtagpki/issue/3173

Signed-off-by: Viktor Ashirov <vashirov@redhat.com>
@vashirov
Copy link
Contributor Author

I'd need some help with the upgrade scripts to update existing installations.

@edewata
Copy link
Contributor

edewata commented May 1, 2020

Thanks for the PR. So this will fix new installations only.

Will the DS automatically fix the ACIs already in the database? Or do we have to find existing ACIs and fix it with ldapmodify? Currently PKI doesn't have an automatic database upgrade mechanism. If you could provide a script (preferrably in Python) that can find the ACIs in the DS and fix them that'll be great.

Copy link
Member

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. Curious about the need for migration (whether DS will handle the upgrade itself or not).

@vashirov
Copy link
Contributor Author

vashirov commented May 4, 2020

DS doesn't handle automatic update of ACIs, but we plan to add an ACI linter to DS healthcheck tool to find these invalid entries and help users/admins fix them.
Strict syntax checking will be disabled by default for now, so that existing installations won't be affected.

@edewata
Copy link
Contributor

edewata commented May 4, 2020

Merging. We can deal with upgrade either manually or automatically later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants