Fix temporary SSL server key removal #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past pkispawn used the same nickname for the temporary and the permanent SSL server certs. Initially it would create the temporary cert and the key, then it would create the permanent cert with the same key, then drop the temporary cert while keeping the key. Recently the code was changed to use separate nicknames to simplify installation which would generate separate keys too. It removed the temporary cert, but not the temporary key. Now the code has been updated to remove the temporary key as well. Some tests have been modified to check for orphaned keys after installation. Resolves: dogtagpki#4103
|
Kudos, SonarCloud Quality Gate passed! |
|
@fmarco76 @ckelleyRH Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past
pkispawnused the same nickname for the temporary and the permanent SSL server certs. Initially it would create the temporary cert and the key, then it would create the permanent cert with the same key, then drop the temporary cert while keeping the key.Recently the code was changed to use separate nicknames to simplify installation which would generate separate keys too. It removed the temporary cert, but not the temporary key. Now the code has been updated to remove the temporary key as well.
Some tests have been modified to check for orphaned keys after installation.
Resolves: #4103