Remove serialVersionUID from classes that don't implement Serializable #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most/all of this is from classes inheriting from LogEvent. In the past LogEvent implemented an interface called ILogEvent, which in turn extended Serializable. ILogEvent no longer exists, so none of these classes are Serializable, so the field is not used and unnecessary.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks @edewata ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most/all of this is from classes inheriting from
LogEvent. In the pastLogEventimplemented an interface calledILogEvent, which in turn extendedSerializable.ILogEventno longer exists, so none of these classes areSerializable, so the field is not used and unnecessary.