Add PKIRealm.engine #4365
Merged
Add PKIRealm.engine #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PKIRealm.engine field has been added to store the CMSEngine instance such that the realm no longer needs to use CMS.getCMSEngine() to get the instance.
|
Kudos, SonarCloud Quality Gate passed! |
ckelleyRH
approved these changes
Mar 15, 2023
Comment on lines
59
to
61
| protected String getName() { | ||
| return "PKIRealm"; | ||
| } |
There was a problem hiding this comment.
Not part of your diff, but this could be this.getClass().getSimpleName() to make it less brittle. The method is not actually used anywhere by the looks of it so it could just be dropped.
There was a problem hiding this comment.
Yeah, IIRC we used to extend an abstract class or implement an interface, I forgot, so that method had to be added. I'll remove it separately later. Thanks!
|
@ckelleyRH @fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PKIRealm.enginefield has been added to store theCMSEngineinstance such that the realm no longer needs to useCMS.getCMSEngine()to get the instance.