Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkidestroy and pki-server remove #4725

Merged
merged 1 commit into from Apr 19, 2024
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Apr 18, 2024

pkidestroy and pki-server remove commands have been modified to work more consistently. Now by default the logs will be retained so the following folders will remain:

  • /var/lib/pki/<instance>
  • /var/lib/pki/<instance>/logs
  • /var/log/pki/<instance> for instances using FHS layout

The tools will also provide an option to remove the logs if they are no longer needed.

The tests have been updated accordingly.

pkidestroy and pki-server remove commands have been modified to
work more consistently. Now by default the logs will be retained
so the following folders will remain:

- /var/lib/pki/<instance>
- /var/lib/pki/<instance>/logs
- /var/log/pki/<instance> for instances using FHS layout

The tools will also provide an option to remove the logs if they
are no longer needed.

The tests have been updated accordingly.
@edewata edewata changed the title Add pki-server remove --remove-logs option Update pkidestroy and pki-server remove Apr 18, 2024
@edewata edewata requested a review from fmarco76 April 18, 2024 19:55
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Apr 19, 2024

@fmarco76 Thanks!

@edewata edewata merged commit 2a4a271 into dogtagpki:master Apr 19, 2024
135 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants