Remove CrlIssuer from template with CRLDP #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladycfu
reviewed
Apr 19, 2024
| @@ -106,8 +102,6 @@ policyset.serverCertSet.10.default.class_id=crlDistributionPointsExtDefaultImpl | |||
| policyset.serverCertSet.10.default.name=CRL Distribution Points Extension Default | |||
| policyset.serverCertSet.10.default.params.crlDistPointsCritical=false | |||
| policyset.serverCertSet.10.default.params.crlDistPointsEnable_0=true | |||
| policyset.serverCertSet.10.default.params.crlDistPointsIssuerName_0=SET_ME_TO_DN_OF_CRL_ISSUER | |||
| policyset.serverCertSet.10.default.params.crlDistPointsIssuerType_0=DirectoryName | |||
There was a problem hiding this comment.
@fmarco76 I'm unclear on this. Are we supposed to remove those two or just leave them blank like this? policyset.serverCertSet.9.default.params.crlDistPointsIssuerName_0=
policyset.serverCertSet.9.default.params.crlDistPointsIssuerType_0=
fmarco76
force-pushed
the
RemoveCRLIssuer
branch
2 times, most recently
from
60f6522
to
ce35920
Compare
CRLIssuer MUST not be included if the issuer is the same issuer of the certificate. Therefore it is update the comment for the user to make it clear. See: https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.13
fmarco76
force-pushed
the
RemoveCRLIssuer
branch
from
ce35920
to
d119b6b
Compare
ladycfu
approved these changes
Apr 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRLIssuer MUST not be included if the issuer is the same issuer of the certificate. Therefore it is removed from the template.
See: https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.13