Fix HTTP Request formatting in AdminConnection #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
fix-pki-console-requests
branch
from
997560a
to
ac6be67
Compare
cipherboy
force-pushed
the
fix-pki-console-requests
branch
4 times, most recently
from
a7c6c2e
to
074f453
Compare
AdminConnection's processRequest method creates a hand-rolled HTTP request to the remote server. This is used by PKI Console when authenticated as an administrator. Because of the recent CVE fix in Tomcat (CVE-2020-1935), Tomcat will no longer accept \n (Line Feed) terminated requests and headers, and instead reject them as a bad request. We fix this by adding the missing and required CR, per HTTP specification. This fixes the following exception in PKIConsole: java.io.IOException: 400 at com.netscape.admin.certsrv.connection.JSSConnection.readHeader(JSSConnection.java:537) at com.netscape.admin.certsrv.connection.JSSConnection.initReadResponse(JSSConnection.java:497) at com.netscape.admin.certsrv.connection.JSSConnection.sendRequest(JSSConnection.java:411) at com.netscape.admin.certsrv.connection.AdminConnection.processRequest(AdminConnection.java:788) at com.netscape.admin.certsrv.connection.AdminConnection.sendRequest(AdminConnection.java:681) at com.netscape.admin.certsrv.connection.AdminConnection.sendRequest(AdminConnection.java:646) at com.netscape.admin.certsrv.connection.AdminConnection.authType(AdminConnection.java:379) at com.netscape.admin.certsrv.CMSServerInfo.getAuthType(CMSServerInfo.java:128) Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
force-pushed
the
fix-pki-console-requests
branch
from
074f453
to
cbe2f4b
Compare
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdminConnection'sprocessRequestmethod creates a hand-rolled HTTPrequest to the remote server. This is used by PKI Console when
authenticated as an administrator. Because of the recent CVE fix in
Tomcat (CVE-2020-1935), Tomcat will no longer accept
\n(Line Feed)terminated requests and headers, and instead reject them as a bad
request. We fix this by adding the missing and required CR, per HTTP
specification.
This fixes the following exception in PKIConsole:
Signed-off-by: Alexander Scheel <ascheel@redhat.com>