Cert module fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewata
approved these changes
Sep 25, 2018
| # audit and CA certs require special flags set in NSSDB | ||
| # TODO: When CA renewal is added, add the corresponding trust attrs for CA | ||
| trust_attributes = None | ||
| if cert_tag == 'audit_signing': |
There was a problem hiding this comment.
Let's add another case for cert_id == 'ca_signing' although we may not support renewing CA signing cert right now. The flag should be "CT,C,C". The "u" flag will automatically be added by NSS if the cert has a corresponding key in the database.
| # TODO: When CA renewal is added, add the corresponding trust attrs for CA | ||
| trust_attributes = None | ||
| if cert_tag == 'audit_signing': | ||
| trust_attributes = 'u,u,Pu' |
There was a problem hiding this comment.
Let's change it to ",,P". The "u" flag will automatically be added by NSS if the cert has a corresponding key in the database.
SilleBille
force-pushed
the
cert_module_fixes
branch
3 times, most recently
from
8190e6b
to
b85d2df
Compare
`pki-server cert-create --serial <serial>` option now accepts both hex and int. This patch syncs up with other modules on processing the user provided --serial option Ticket: https://pagure.io/dogtagpki/issue/3067 Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
The audit_signing and ca_signing require special flags to be set in nssdb to render it useful. This patch fixes this issue. Ticket: https://pagure.io/dogtagpki/issue/3066 Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
SilleBille
force-pushed
the
cert_module_fixes
branch
from
b85d2df
to
3adba35
Compare
SilleBille
added
Enhancement
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: