Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist::CheckConflicts runtime dependecy #13

Closed
nunorc opened this issue Aug 16, 2012 · 6 comments
Closed

Dist::CheckConflicts runtime dependecy #13

nunorc opened this issue Aug 16, 2012 · 6 comments

Comments

@nunorc
Copy link

nunorc commented Aug 16, 2012

Greetings,

It seems that Dist::CheckConflicts is not required during runtime, and is only required during configuration and building. If this is correct, could the runtime dependency for Dist::CheckConflicts be removed from Makefile.PL and friends? The issue came up during the process of packaging version 0.007 of the module, and this could save up a package dependency.

Best regards

@doherty
Copy link
Owner

doherty commented Aug 17, 2012

I'd be interested in accepting a patch for this, but it isn't a high priority for me.

@nunorc
Copy link
Author

nunorc commented Aug 29, 2012

Would something like this be enough? Tests still pass.

nunorc@e117d67

@doherty
Copy link
Owner

doherty commented Sep 1, 2012

Sorry, the file you edited is automatically generated by Dist::Zilla - a proper solution should probably reside in Dist::Zilla::Plugin::Conflicts

@doherty
Copy link
Owner

doherty commented Oct 5, 2012

@doherty
Copy link
Owner

doherty commented Oct 5, 2012

I could potentially require autodie 2.11 as a dependency, although it isn't actually required. This would guarantee that the conflict never arises.

@doherty
Copy link
Owner

doherty commented Aug 3, 2014

This was fixed in the latest release.

@doherty doherty closed this as completed Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants