Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikt2dsl: Improve the README.md #1

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Conversation

jonadem
Copy link
Contributor

@jonadem jonadem commented Jun 8, 2017

No description provided.

@dohliam
Copy link
Owner

dohliam commented Jun 9, 2017

Good idea -- thanks for the PR!

@dohliam dohliam merged commit 046f1b5 into dohliam:master Jun 9, 2017
@jonadem
Copy link
Contributor Author

jonadem commented Jun 9, 2017

Another thing that can be done for the usability is to improve the behavior when the first line is not well formatted (return a comprehensive output message). As I didn't know I you were still active, I didn't put too much energy in it (and I don't know Ruby).

@dohliam
Copy link
Owner

dohliam commented Jun 10, 2017

I might look at this next time I try to update the wiktionary-based dictionaries. I can't recall running into any problems with the header lines last time, but the format may have changed since then.

If you could tell me which specific dictionaries you tried to use that gave you errors, it would be really helpful for implementing this.

@jonadem
Copy link
Contributor Author

jonadem commented Jun 12, 2017

I have generated en-fr and en-es dictionaries and none had any header.

Hope this helps

@dohliam
Copy link
Owner

dohliam commented Jun 12, 2017

Thanks, that's really helpful! I'll try to regenerate the en-fr and en-es dictionaries when I have some time. It sounds like the format has changed, so the script definitely needs an update as well. In the meantime I'll create an issue for this so it's on the to do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants