Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention draft-ietf-dprive-padding-policy which provides guidelines #207

Merged
merged 3 commits into from Jul 25, 2018

Conversation

loganaden
Copy link
Contributor

on padding length which was absent from RFC 7830.

on padding length which was absent from RFC 7830.
@@ -631,7 +631,8 @@ DNS queries.
HTTP/2 provides further advice about the use of compression
({{RFC7540}} Section 10.6) and padding ({{RFC7540}} Section 10.7 ).
DoH Servers can also add DNS padding {{RFC7830}} if the DoH client requests
it in the DNS query.
it in the DNS query. Additionally, guidelines for choosing the padding length
can be found in {{draft-ietf-dprive-padding-policy}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a reference to experimental phrased as if its standards track guidance...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can modify it, and re-send a pull request. dprive-padding-policy has been implemented in open source software such as pydig & knot.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I would perhaps say "initial attempts to offer guidance on choosing the padding length..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moonshiner for the suggestion.

@paulehoffman paulehoffman merged commit 82b9d67 into dohwg:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants