Problem with flow history calculations when there are missing years

[rmhirsch49]

Laura: I found a bug, fairly serious, in the makeAnnualSeries function that has consequences for a variety of other functions like plotFlowSingle, printSeries, plotFourStats and plotFour. I worked at it and found that I was able to write a fix for it (all the changes are in the loop near the bottom that goes from istat in 1:8. I've attached my code, but please look at it and also test it yourself. A good site to test it on is 11336580 (has a lot of missing data). Probably should be tested on one with no missing data (my changes should be of no consequence there.

So, this needs to go up on CRAN and GRAN fairly soon. It is a bad bug. You can see what I mean when you run it through plotFourStats without fixing makeAnnualSeries.

Thanks.

Bob

I'll send the code as an R file by email. Funny that they don't let me attach an R file in GitHub.

makeAnnualSeriesFixed.txt

[ldecicco-USGS]

I should be able to get to this this afternoon, or tomorrow.

[ldecicco-USGS]

Pushing to GRAN and CRAN shortly.

[rmhirsch49]

Super. Thanks. What version number will that have on it?

Bob

On Tue, Jul 26, 2016 at 12:30 PM, Laura DeCicco notifications@github.com
wrote:

Pushing to GRAN and CRAN shortly.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#92 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABHd0V61QXzJWKml9Mno4oTwt49vzSZNks5qZjYxgaJpZM4JRNN6
.

---

• Robert M. Hirsch
• Research Hydrologist
• 432 National Center rhirsch@usgs.gov
• U.S. Geological Survey ph 703-648-5888
• Reston, VA 20192 http://profile.usgs.gov/rhirsch

  ---

[ldecicco-USGS]

2.6.0