Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle no service account case #8

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

jefimm
Copy link
Contributor

@jefimm jefimm commented Nov 29, 2021

No description provided.

@bloodsper
Copy link

hey @jefimm, currently forked this repo for our org and fixing a bunch of dependencies and build issues, was there a reason you handled no service account case?

@jefimm
Copy link
Contributor Author

jefimm commented Dec 14, 2021

when node starts some gke daemons are started that have no serviceaccount set

Copy link
Collaborator

@alexei-led alexei-led left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexei-led alexei-led merged commit 88c7a61 into doitintl:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants