fix lint errors; add tests to CI fixes #19

.github/workflows/build.yaml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-18.04
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v2
 
     - name: decide on tag
       id: decide_tag

.github/workflows/test.yaml

@@ -0,0 +1,38 @@
+name: Test
+on:
+  push:
+    branches:
+      - '*'
+    tags:
+      - '*'
+    paths-ignore:
+      - 'docs/**'
+      - 'deploy/**'
+      - '*.md'
+  pull_request:
+    branches:
+      - '*'
+env:
+  GOPROXY: https://proxy.golang.org
+  CGO_ENABLED: 0
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.x
+
+      - name: Lint
+        run: |
+          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.39
+          golangci-lint run --timeout=5m -v -c .golangci.yaml ./cmd/...
+
+      - name: Test
+        run: |
+            go test -v ./cmd/...

.golangci.yaml

@@ -15,7 +15,7 @@ linters-settings:
   misspell:
     locale: US
   lll:
-    line-length: 140
+    line-length: 160
   goimports:
     local-prefixes: github.com/golangci/golangci-lint
   gocritic:

Dockerfile

@@ -7,7 +7,7 @@ FROM golang:1.16-alpine AS builder
 
 # curl git bash
 RUN apk add --no-cache curl git bash make
-COPY --from=golangci/golangci-lint:v1.24-alpine /usr/bin/golangci-lint /usr/bin
+COPY --from=golangci/golangci-lint:v1.39-alpine /usr/bin/golangci-lint /usr/bin
 
 #
 # ----- Build and Test Image -----

cmd/secrets-init-webhook/main.go

@@ -9,19 +9,17 @@ import (
 	"strings"
 
 	"github.com/doitintl/kube-secrets-init/cmd/secrets-init-webhook/registry"
-
+	"github.com/pkg/errors"
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	log "github.com/sirupsen/logrus"
-
 	whhttp "github.com/slok/kubewebhook/v2/pkg/http"
 	whlogrus "github.com/slok/kubewebhook/v2/pkg/log/logrus"
 	metrics "github.com/slok/kubewebhook/v2/pkg/metrics/prometheus"
 	whmodel "github.com/slok/kubewebhook/v2/pkg/model"
 	wh "github.com/slok/kubewebhook/v2/pkg/webhook"
 	"github.com/slok/kubewebhook/v2/pkg/webhook/mutating"
 	"github.com/urfave/cli"
-
 	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/api/resource"
@@ -92,7 +90,7 @@ func serveMetrics(addr string) {
 	}
 }
 
-func handlerFor(config mutating.WebhookConfig, recorder *metrics.Recorder, logger *log.Logger) http.Handler {
+func handlerFor(config mutating.WebhookConfig, recorder wh.MetricsRecorder, logger *log.Logger) http.Handler {
 	webhook, err := mutating.NewWebhook(config)
 	if err != nil {
 		logger.WithError(err).Fatal("error creating webhook")
@@ -397,7 +395,10 @@ func before(c *cli.Context) error {
 func (mw *mutatingWebhook) secretsMutator(ctx context.Context, ar *whmodel.AdmissionReview, obj metav1.Object) (*mutating.MutatorResult, error) {
 	switch v := obj.(type) {
 	case *corev1.Pod:
-		mw.mutatePod(v, ar.Namespace, ar.DryRun)
+		err := mw.mutatePod(v, ar.Namespace, ar.DryRun)
+		if err != nil {
+			return nil, errors.Wrapf(err, "failed to mutate pod: %s", v.Name)
+		}
 		return &mutating.MutatorResult{MutatedObject: v}, nil
 	default:
 		return &mutating.MutatorResult{}, nil

go.mod

@@ -9,6 +9,7 @@ require (
 	github.com/docker/go-units v0.4.0 // indirect
 	github.com/heroku/docker-registry-client v0.0.0-20190909225348-afc9e1acc3d5
 	github.com/opencontainers/image-spec v1.0.1
+	github.com/pkg/errors v0.9.1 // indirect
 	github.com/prometheus/client_golang v1.10.0
 	github.com/sirupsen/logrus v1.8.1
 	github.com/slok/kubewebhook/v2 v2.0.0