Update registry client v2 #31
Conversation
|
@alexei-led can you review this pull request, please? this pull request i have done to fix error linet from @sagikazarmark sagikazarmark (#30) I need this change please friend |
| @@ -11,7 +12,7 @@ import ( | |||
| "github.com/Masterminds/semver/v3" | |||
|
|
|||
| "github.com/doitintl/kube-secrets-init/cmd/secrets-init-webhook/registry" | |||
| "github.com/pkg/errors" | |||
| _ "github.com/pkg/errors" | |||
There was a problem hiding this comment.
This doesn't really make sense if it's imported again above.
There was a problem hiding this comment.
shit, I only wrote this so that the test would pass, since when I imported from your code this gave me an error
|
Why don't you tell me what the proper fix is instead? This is certainly not the appropriate way of resubmitting my original PR since it's not abandoned. |
|
Looks like updating the Go version was the solution. Builds pass now in the original PR. |
|
@sagikazarmark I'm sorry, it's true that I should have written to you... , but seeing that your "pull request" remained there without movement, I wanted to press, anyway we can close the pull request that it generates and continue with yours, I'm really sorry, go into desperation mode to occupy something cleaner |
Fixes #22
Fixes #24
fix error linet from sagikazarmark