Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign static IPs to existing nodes, not just newly added ones #16

Closed
WilliamDenniss opened this issue Jun 22, 2018 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@WilliamDenniss
Copy link

Currently static IPs are only assigned to nodes created after the kubeIP deployment is available.

This means that if a node is added while the deployment is unavailable (e.g. it was disrupted during a node upgrade event), it won't get a static IP. It also means that any nodes existing before the deployment is available won't get static IPs assigned.

I'd suggest checking all existing nodes on boot, and at a regular interval as well, to ensure consistency.

In addition to the boot-time and unavailable kubeIP deployment cases, if you have the exact number of nodes as IPs, then during a node repair where the new node is created before the static IP is released, it won't get an assigned IP (due to none being available). If the kubeIP controller implemented the behavior to check all nodes at a regular interval, the static IP may have been freed up and could be assigned.

@avivl avivl self-assigned this Jun 22, 2018
@avivl avivl added the enhancement New feature or request label Jun 22, 2018
avivl added a commit that referenced this issue Jun 24, 2018
`KUBEIP_FORCEASSIGNMENT` which defaults to true will check on startup and every 5 minutes if there are some nodes in the pool that are not assigned to a reserved address. If such nodes will be found then kubeip will assign a reserved address (if one is available to them)
avivl added a commit that referenced this issue Jun 24, 2018
@avivl
Copy link
Contributor

avivl commented Jun 24, 2018

@WilliamDenniss
KUBEIP_FORCEASSIGNMENT which defaults to true will check on startup and every 5 minutes if there are some nodes in the pool that are not assigned to a reserved address. If such nodes will be found then kubeip will assign a reserved address (if one is available to them)

@avivl avivl closed this as completed Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants