Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated gh actions functions #97

Merged

Conversation

kevholmes
Copy link
Contributor

This attempts to resolve #96. Most of these errors being surfaced were coming from outdated Actions such as docker/login-action or docker/build-push-action. I've updated their major semantic versions to the latest available which should eliminate most errors. There were a couple related to us using set-output within the id: prep step in our build.yaml Workflow itself. I've removed the outputs that are not consumed (date, version) and converted the tags output var to utilize the newer style of echo "tags=${TAGS}" >> $GITHUB_OUTPUT.

@kevholmes
Copy link
Contributor Author

I just noticed that the logic used to run a build on external PRs from a fork (like this one) fail to run the login to Dockerhub step due to the external fork not being able to utilize this repo's Secrets (expected.) I'll add in a conditional for that step to not run if this is a pull_request as it's unneeded there - we just want to make sure the project itself builds.

Screenshot 2023-03-22 at 10 37 31

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kevholmes kevholmes marked this pull request as ready for review March 22, 2023 14:57
@spark2ignite spark2ignite self-requested a review March 22, 2023 15:03
@spark2ignite spark2ignite merged commit 3b7b080 into doitintl:master Mar 22, 2023
@kevholmes kevholmes deleted the fix/deprecated_gh_actions_functions branch March 22, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.yaml Action is using soon-to-be-deprecated calls like "save-state" and "set-output"
2 participants