Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exit-early flag when provider or secret not found #36

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

hhollenstain
Copy link
Contributor

We ran into an issue where an application started where the provider timed out.

time="2023-05-22T17:43:31Z" level=error msg="failed to resolve secrets" error="failed to get secret from Google Secret Manager: rpc error: code = DeadlineExceeded desc = context deadline exceeded"

Ideally we want to get an option to exit early when the provider fails to connect and or fails to find a secret. In our use case it is easier to track down API outage or improper secret configuration with a non zero exit.

This would include a feature for #21

With this setup you can use either --exit-early bool flag or env EXIT_EARLY=[true|false]

./secrets-init --provider google  -- env |grep -i 'TEST_ENV'
ERRO[0000] failed to resolve secrets                     error="failed to get secret from Google Secret Manager: rpc error: code = NotFound desc = Secret [projects/<ACCOUNTID>/secrets/NAME_OF_SECRET_broken] not found or has no versions."
TEST_ENV_WORKING=gcp:secretmanager:projects/<ACCOUNTID>/secrets/NAME_OF_SECRET
TEST_ENV_BROKEN=gcp:secretmanager:projects/<ACCOUNTID>/secrets/NAME_OF_SECRET_broken
./secrets-init --provider google --exit-early  -- env |grep -i TEST_ENV
ERRO[0000] failed to resolve secrets                     error="failed to get secret from Google Secret Manager: rpc error: code = NotFound desc = Secret [projects/<ACCOUNTID>/secrets/NAME_OF_SECRET_broken] not found or has no versions."
ERRO[0000] Exiting early unable to retrieve secrets   

envVar set

export EXIT_EARLY=true
./secrets-init --provider google -- env |grep -i TEST_ENV
ERRO[0000] failed to resolve secrets                     error="failed to get secret from Google Secret Manager: rpc error: code = NotFound desc = Secret [projects/<ACCOUNTID>/secrets/NAME_OF_SECRET_broken] not found or has no versions."
ERRO[0000] Exiting early unable to retrieve secrets    

@alexei-led alexei-led merged commit faf0ad4 into doitintl:master Sep 6, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants