Skip to content
This repository has been archived by the owner on Jul 23, 2021. It is now read-only.

Gem Maintenance request #20

Open
ngudbhav opened this issue May 23, 2021 · 5 comments
Open

Gem Maintenance request #20

ngudbhav opened this issue May 23, 2021 · 5 comments

Comments

@ngudbhav
Copy link

Hi @doits

Thank you for amazing this Gem. It helped me a lot to enable automatic eslint checks via Jenkins on a private repository.

Since, you are no longer maintaining this gem, Can I maintain this? I have a lot of ideas that I think can be used to enhance the functionality. Do let me know if you would like to have a chat around this.

Thank you

@doits
Copy link
Owner

doits commented May 25, 2021

Hi @ngudbhav,

thanks for stepping up. I'd be glad if you take it over and enhance it with more functionality and keep it up to date.

I have the following migration steps in mind:

  • You fork the repo and change the name a little bit (maybe pronto-eslint_global or something) --> This name even might better fit the purpose, since it is all about eslint being installed globally, but feel free to name it however you want
  • Then you release a new version to rubygems
  • I update the readme and description of this gem to point to your repo and gem as a successor, so users will easily find it and can change to it
  • I finally archive this repo

What do you think?

@ngudbhav
Copy link
Author

Thank you for your reply. There are three concerns that I have.

  1. There are two already listed gems for eslint in pronto main repository. Too many gems doing the same work may be clutter.
  2. If we keep the same name, we can cover a larger audience in contrast to starting a new one.
  3. Updating the same gem would help us serve it better. We can directly update the upstream.

The following steps can be taken to tackle these issues.

  1. You initiate the transfer of the repository. (This will keep the issues, PR, and the comments intact and automatically redirect users to the new repository)

One demerit in following these steps would be that you will have access to this repository as a collaborator and not as the owner.

These are my thoughts. I would be happy to amend them as per your suggestions.

@doits
Copy link
Owner

doits commented May 28, 2021

Thanks for your feedback. About your concerns:

There are two already listed gems for eslint in pronto main repository. Too many gems doing the same work may be clutter.

Yes, absolutely right. If we follow my path of forking and renaming the gem, pronto-eslint_npm should be removed from pronto main repository, because it was superseded by the new one. The successor should take its place, so there would still be listed two gems only.

If we keep the same name, we can cover a larger audience in contrast to starting a new one.

Yes, there will be a loss, because not everybody will migrate. But everybody maintaining their app will be sooner or later, at latest when a new incompatible pronto version comes out and they want to update. So it is mostly a loss for a short time.

And I'd make it as prominent as possible and maybe would release a new version which will print a post install message to switch to the new gem for example, write it prominently in the README here for sure. So users will get to know about it.

Updating the same gem would help us serve it better. We can directly update the upstream.

I'm not sure what you mean by "upstream" so can't follow here. If you mean the git upstream, the fork would be the new official upstream?

You initiate the transfer of the repository. (This will keep the issues, PR, and the comments intact and automatically redirect users to the new repository)

The last point is my concern exactly: To automatically make users switch without their consent. I want to make it as easy as possible for them but they need to know that maintenance/ownership changed and then can decide to update their Gemfile or not.

In addition I keep the archive of the current repository under my name so history can be followed exactly. There is no need to transfer something in rubygems, either.

Could I maybe convince you to take my route, even with the then unavoidable loss of some users?

@ngudbhav
Copy link
Author

Thanks for the detailed review of my concerns.
I have forked the repository and changed its name link
I will also release a new version on Rubygems very soon.

Once again, Thanks a lot.

@doits
Copy link
Owner

doits commented Jul 23, 2021

Thanks! I updated the README here to reflect the new fork. I wish you the best with taking over the project!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants