Fix some selectable functionality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagalbot
approved these changes
Aug 29, 2019
| @@ -7,35 +7,46 @@ export default { | |||
|
|
|||
| watch: { | |||
| filteredOptions() { | |||
| this.typeAheadPointer = 0 | |||
There was a problem hiding this comment.
How about this to find the first selectable index:
this.typeAheadPointer = this.filteredOptions.findIndex(option => this.selectable(option))Haven't tested, but I think that'd work.
There was a problem hiding this comment.
Yes I did consider using findIndex, but I noticed that IE doesn't support it. Unless the transpilation process would automatically include a polyfill?
There was a problem hiding this comment.
(Waiting until this is resolved and then I will merge it)
There was a problem hiding this comment.
@tobyzerner good call! I just searched the dist, and it looks like I do have a reference to find() in there that's not polyfilled. I haven't heard any complaints there, but probably simpler to just leave it as is.
2 tasks
sagalbot
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issues I found in sagalbot#921 (comment)