[d3d9] COM Overhaul, fix memory/resource leaks in reset/deletion/stat…

…eblocks

Fixes and matches ref-counting for device child resources to native d3d9.
Fixes memory and resource leaks in stateblocks, deletion and device resetting.

src/d3d9/d3d9_buffer.h

@@ -64,10 +64,6 @@ namespace dxvk {
 
   };
 
-  inline D3D9CommonBuffer* GetCommonBuffer(D3D9VertexBuffer* pResource) {
-    return pResource != nullptr ? pResource->GetCommonBuffer() : nullptr;
-  }
-
   using D3D9IndexBufferBase = D3D9Buffer<IDirect3DIndexBuffer9>;
   class D3D9IndexBuffer final : public D3D9IndexBufferBase {
 
@@ -88,7 +84,8 @@ namespace dxvk {
 
   };
 
-  inline D3D9CommonBuffer* GetCommonBuffer(D3D9IndexBuffer* pResource) {
+  template <typename T>
+  inline D3D9CommonBuffer* GetCommonBuffer(const T& pResource) {
     return pResource != nullptr ? pResource->GetCommonBuffer() : nullptr;
   }
 

src/d3d9/d3d9_common_buffer.cpp

@@ -1,5 +1,6 @@
 #include "d3d9_common_buffer.h"
 
+#include "d3d9_device.h"
 #include "d3d9_util.h"
 
 namespace dxvk {

src/d3d9/d3d9_common_buffer.h

@@ -3,6 +3,7 @@
 #include "../dxvk/dxvk_device.h"
 
 #include "d3d9_device_child.h"
+#include "d3d9_format.h"
 
 namespace dxvk {
 

src/d3d9/d3d9_common_texture.cpp

@@ -1,5 +1,7 @@
 #include "d3d9_common_texture.h"
+
 #include "d3d9_util.h"
+#include "d3d9_device.h"
 
 #include <algorithm>
 
@@ -290,6 +292,18 @@ namespace dxvk {
   }
 
 
+  void D3D9CommonTexture::RecreateSampledView(UINT Lod) {
+    // This will be a no-op for SYSTEMMEM types given we
+    // don't expose the cap to allow texturing with them.
+    if (unlikely(m_mapMode == D3D9_COMMON_TEXTURE_MAP_MODE_SYSTEMMEM))
+      return;
+
+    const D3D9_VK_FORMAT_MAPPING formatInfo = m_device->LookupFormat(m_desc.Format);
+
+    m_views.Sample = CreateColorViewPair(formatInfo, AllLayers, VK_IMAGE_USAGE_SAMPLED_BIT, Lod);
+  }
+
+
   BOOL D3D9CommonTexture::DetermineShadowState() const {
     static std::array<D3D9Format, 3> blacklist = {
       D3D9Format::INTZ, D3D9Format::DF16, D3D9Format::DF24

src/d3d9/d3d9_common_texture.h

@@ -1,12 +1,15 @@
 #pragma once
 
-#include "d3d9_device.h"
 #include "d3d9_format.h"
+#include "d3d9_util.h"
+#include "d3d9_caps.h"
 
 #include "../dxvk/dxvk_device.h"
 
 namespace dxvk {
 
+  class D3D9DeviceEx;
+
   /**
    * \brief Image memory mapping mode
    * 
@@ -300,16 +303,7 @@ namespace dxvk {
      * Recreates the main view of the sampler w/ a specific LOD.
      * SetLOD only works on MANAGED textures so this is A-okay.
      */
-    void RecreateSampledView(UINT Lod) {
-      // This will be a no-op for SYSTEMMEM types given we
-      // don't expose the cap to allow texturing with them.
-      if (unlikely(m_mapMode == D3D9_COMMON_TEXTURE_MAP_MODE_SYSTEMMEM))
-        return;
-
-      const D3D9_VK_FORMAT_MAPPING formatInfo = m_device->LookupFormat(m_desc.Format);
-
-      m_views.Sample = CreateColorViewPair(formatInfo, AllLayers, VK_IMAGE_USAGE_SAMPLED_BIT, Lod);
-    }
+    void RecreateSampledView(UINT Lod);
 
     /**
      * \brief Extent

src/d3d9/d3d9_constant_set.h

@@ -2,6 +2,8 @@
 
 #include "d3d9_caps.h"
 
+#include "../dxvk/dxvk_buffer.h"
+
 #include "../dxso/dxso_isgn.h"
 
 #include "../util/util_math.h"