Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GW2 flickering texture with 1.5.1 #1329

Closed
logan001 opened this issue Jan 9, 2020 · 27 comments
Closed

GW2 flickering texture with 1.5.1 #1329

logan001 opened this issue Jan 9, 2020 · 27 comments
Labels

Comments

@logan001
Copy link

logan001 commented Jan 9, 2020

With 1.5.1 seems to be some flickering in textures when you rotate camera.
i've tested the game in windows too. and i get the same flickering with dxvk
The trace is also from windows using dx

System information

  • GPU: nvidia 970
  • Driver: 440.43.02
  • Wine version: 5.0..... and windows 10
  • DXVK version: 1.5.1

Apitrace and logs files here. Logs are also from windows.

@logan001
Copy link
Author

Seems that flickering starts with b738c42

@doitsujin
Copy link
Owner

doitsujin commented Jan 10, 2020

Can you please post a screenshot that highlights what the issue is? The apitrace looks 100% fine at a first glance, but I also don't know how it's supposed to look.

Depth bias issues aren't really something that can be fixed at the moment due to the lack of Vulkan support for D3D9 depth bias.

@logan001
Copy link
Author

i've uploaded a short movie there. Watch this area

Untitled

this flickering disappear if i zoom in. it seems to happen on certain distance from the texture.
I've also notice some small black triangles on the ground while flying over (in game :D). its like the triangles are render as i get close to them. but that is hard to duplicate cause i have to take similar paths and i've notice this only 2 times so far.

@Berobad
Copy link

Berobad commented Jan 11, 2020

Tried to recreate it ingame, but RADV and AMDVLK show no problem here.
Tried DXVK 1.5.1, 1.5.0 and D9VK 0.40, 0.30 with no visual difference between them.

@logan001
Copy link
Author

these are my settings. can you try with these settings? try 1.5.1 and walk around and look for far away objects.

GW_settings

@logan001
Copy link
Author

here is another sample
this is with 1.5.1
Screenshot_20200111_091651
and this is with b376417
Screenshot_20200111_092547

those black triangle change as i move around or just rotate camera while staying in same place

@Berobad
Copy link

Berobad commented Jan 11, 2020

I played around with the settings when I tried to recreate it, but with your settings on the same spot, I can move the camera around as much as I want with both RADV, and AMDVLK with no visual bugs.

Guild Wars 2 screen without vkbasalt

@logan001
Copy link
Author

logan001 commented Jan 11, 2020

i see. is this an nvidia only problem? it would be nice if someone else with nvidia can try this.

@jrugia
Copy link

jrugia commented Jan 13, 2020

i see. is this an nvidia only problem? it would be nice if someone else with nvidia can try this.

Never saw those triangles ingame. I will go to the same spot using your settings and report back.

@jrugia
Copy link

jrugia commented Jan 14, 2020

I've succeeded in reproducing the issue on my system, apparently it only occurs when setting the Shadows to 'Ultra'. I couldn't see them before because I always keep it at 'Medium' to avoid the fps from tanking too low.

I played around with the other graphics settings and the issue is present regardless of what I set, the only way to remove them is by setting the Shadows to 'High' or any lower setting. Furthermore it doesn't seem to happen in all areas either, I tried a few maps and everything worked perfectly.

Later tomorrow I will give it a try on on my laptop with Intel HD (not much of a gaming system but should be enough indication if it's an Nvidia exclusive issue or not).

GW2

Driver version: 440.43.02
GPU: RTX 2060 Super

@CME42
Copy link
Contributor

CME42 commented Jan 14, 2020

can you please try this patch?

index 50be2daf..58e923b3 100644
--- a/src/d3d9/d3d9_util.h
+++ b/src/d3d9/d3d9_util.h
@@ -182,10 +182,9 @@ namespace dxvk {
       case VK_FORMAT_D16_UNORM:
         return float(1 << 16);
 
-      case VK_FORMAT_D24_UNORM_S8_UINT:
-        return float(1 << 24);
 
       default:
+      case VK_FORMAT_D24_UNORM_S8_UINT:
       case VK_FORMAT_D32_SFLOAT_S8_UINT:
       case VK_FORMAT_D32_SFLOAT:
         return float(1 << 23);

@Joshua-Ashton
Copy link
Collaborator

There might be an extra scale NV applies here for depth bias actually -- I don't see how this can happen for VK_FORMAT_D24_UNORM_S8_UINT unless that is the case.

@logan001
Copy link
Author

the patch seems to fix it.

@doitsujin doitsujin added the d3d9 label Jan 16, 2020
@logan001
Copy link
Author

and only with nvidia apparently.
i've uploaded another trace taken where these triangles are visible.

@logan001
Copy link
Author

this happens only with dxvk on both windows or wine. without dxvk there is no issue. also this seems to happen only with nvida card when shadow is at max (see jrugia comment)

@logan001
Copy link
Author

the bug is not about the flickering that occurs while walking when almost entire screen turns black for a split second . that is present with dx9 too. it feels like the game tries to load texture for the map or something. it happens more often when you run with pets.
this bug is about some texture not rendering well in certain angles or something.

@logan001
Copy link
Author

that video.... i have no clue.

@logan001
Copy link
Author

logan001 commented Dec 5, 2020

its not fixed. the bug is still there. its just that this place or probably some more places are fixed. i have to make another trace where the bug is still there.

@logan001
Copy link
Author

logan001 commented Dec 6, 2020

here it is
Untitled
and here is the new trace
what i've also notice aside the dark/flickering triangle is that the shadow of the character on the ground will turn into a circle when you go high above ground.

@CME42
Copy link
Contributor

CME42 commented Dec 7, 2020

This is also due to depth bias, use my old patch as a workaround until there is a proper fix: #1329 (comment)

@logan001
Copy link
Author

logan001 commented Dec 7, 2020

:) i know the patch works. its just another example of the bug, cause the area that i mention previously got fixed somehow (game or video driver)

@Iglu47
Copy link

Iglu47 commented Aug 27, 2022

just put together some information into one post

Description issue

Guild Wars 2 (on dx9 mode) has shadow issues. Seems to be a problem with Nvidia only.

Apitrace

since it is known that dx9 support will be removed from this game (oneday), I will keep apitrace for tests on replays.

Proper solution are still in progress

Video

dxvk-master.mp4
dxvk-with-patches.mp4

@Iglu47
Copy link

Iglu47 commented Nov 9, 2022

@logan001 e30b783 helps for me, maybe you know other locations in the game where the issue remains on current master?
(as far as I understand, this is not a proper solution, so it's probably preferable to keep this thread open)

@LingMan
Copy link

LingMan commented Apr 12, 2023

I can reproduce the issue from #1329 (comment) on AMD with the DX11 renderer and DXVK 2.1 (which contains e30b783, but that would only help DX9 on NV anyway). Screenshot is from the north east of Snowden Drifts:
Screenshot from 2023-04-12 23-57-55

@Blisto91
Copy link
Contributor

The game have quite alot of visual bugs on its own from square shadows at Ultra shadows setting to flickering lights on the terrain. I'd except the above to be a game issue but I'll check it out to make sure thanks.

@Blisto91
Copy link
Contributor

Tried checking out both @Iglu47's (posted on Discord) and @LingMan's issues ingame but couldn't reproduce those. (tho i don't have flying mount for the one above). But i did reproduce similar in the area which also showed in native game on Windows. So reported with the ingame bug tool.

@K0bin
Copy link
Collaborator

K0bin commented Apr 18, 2023

GW2 no longer supports D3D9.

@K0bin K0bin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants